[PATCH] D151523: [ASTStructuralEquivalence] Fix crash when ObjCCategoryDecl doesn't have corresponding ObjCInterfaceDecl.
Volodymyr Sapsai via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu May 25 18:23:44 PDT 2023
vsapsai added a comment.
Kinda a follow-up to D121176 <https://reviews.llvm.org/D121176>.
One big alternative that I've considered is to store interface name in `ObjCCategoryDecl` because when we parse `@interface InterfaceName(CategoryName)` we know the interface name. The intention was to allow
@interface A(X) @end
and
@interface A @end
@interface A(X) @end
as equivalent. But I'm not convinced it is the right call and that's why it doesn't justify the extra effort.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151523/new/
https://reviews.llvm.org/D151523
More information about the cfe-commits
mailing list