[PATCH] D151492: Add fastmath attributes to llvm.call_intrinsic

Lily Orth-Smith via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 25 13:45:40 PDT 2023


electriclilies added inline comments.


================
Comment at: mlir/lib/Target/LLVMIR/Dialect/LLVMIR/LLVMToLLVMIRTranslation.cpp:130
 
-  llvm::CallInst *inst =
       builder.CreateCall(fn, moduleTranslation.lookupValues(op.getOperands()));
----------------
ftynse wrote:
> Don't use `auto` unless the type is obvious from context (e.g., the RHS is a cast) or difficult to spell.
This auto was already here, I changed it in previous commit. It showed up in the diff because I hadn't squashed my changes yet.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151492/new/

https://reviews.llvm.org/D151492



More information about the cfe-commits mailing list