[PATCH] D149495: [RISCV] Add support for V extension in SiFive7

Philip Reames via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 25 13:38:51 PDT 2023


reames added a comment.

In D149495#4373796 <https://reviews.llvm.org/D149495#4373796>, @michaelmaitland wrote:

> In D149495#4373768 <https://reviews.llvm.org/D149495#4373768>, @reames wrote:
>
>> Let's go ahead and land this as is, we can rework the stylistic pieces once the linked patches land.
>
> This has landed in https://reviews.llvm.org/rG1a855819a87f426bdbd83c815fa47ca01fdf928f. I raised my question regarding examples in my previous comment on this post because I am starting to rework the stylistic concerns raised by @pcwang-thead. However, I will wait until Wang's patches land before making any modifications to style.

My apologies, I read right past the commit in the history.  Oops.  Sorry for the noise!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149495/new/

https://reviews.llvm.org/D149495



More information about the cfe-commits mailing list