[PATCH] D151492: Add fastmath attributes to llvm.call_intrinsic

[Alex Zinenko via Phabricator via cfe-commits]

ftynse added inline comments.


================
Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:367
   // that can be valid on the real entry.
-  // This is what I want to do
   AttributeList NewAttrs = AttributeList::get(Ctx, AttributeList::FunctionIndex,
----------------
This cleanup should go in a separate commit.


================
Comment at: mlir/lib/Target/LLVMIR/Dialect/LLVMIR/LLVMToLLVMIRTranslation.cpp:130
 
-  llvm::CallInst *inst =
       builder.CreateCall(fn, moduleTranslation.lookupValues(op.getOperands()));
----------------
Don't use `auto` unless the type is obvious from context (e.g., the RHS is a cast) or difficult to spell.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151492/new/

https://reviews.llvm.org/D151492