[PATCH] D151365: [Sema] cast to CXXRecordDecl correctly when diag a default comparison method

[Erich Keane via Phabricator via cfe-commits]

erichkeane added inline comments.


================
Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:968
+                .getNonReferenceType()
+                ->getLocallyUnqualifiedSingleStepDesugaredType();
         Diags.Report(Active->PointOfInstantiation,
----------------
This doesn't seem right to me?  I think you just want the unqualified, non-reference type here.  I suspect you don't really want to do Desugaring at all, since then you lose the typedef information (so something like std::string will be confusing).

So I think you just want: `.getNonReferenceType().getUnqualifiedType()`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151365/new/

https://reviews.llvm.org/D151365