[PATCH] D151349: [HIP] emit macro `__HIP_NO_IMAGE_SUPPORT`

[Yaxun Liu via Phabricator via cfe-commits]

yaxunl added a comment.

In D151349#4372695 <https://reviews.llvm.org/D151349#4372695>, @arsenm wrote:

> You seem to be defining a new subtarget feature without actually defining the underlying feature. I thought the issue was specific missing image instructions, which is already covered by extended-image-insts

gfx90a does not have extended-image-insts but supports image/texture API's in HIP. Brian suggested to determine whether HIP image is supported based on whether the subtarget has image-insts.

I thought image-insts is a subtarget feature as it is defined in https://github.com/llvm/llvm-project/blob/main/llvm/lib/Target/AMDGPU/AMDGPU.td#L499

Did I miss something?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151349/new/

https://reviews.llvm.org/D151349