[PATCH] D150528: [Clang][Attribute] Improve the AST/diagnoses fidelity of alignas and _Alignas

[Erich Keane via Phabricator via cfe-commits]

erichkeane added a comment.

Still LGTM, thanks!



================
Comment at: clang/lib/AST/AttrImpl.cpp:247
+
+  if (isAlignmentExpr()) {
+    return alignmentExpr
----------------
yronglin wrote:
> erichkeane wrote:
> > Typically we don't do curleys on a single-statement... but I am on the fence due to how complicated it is below.
> I've updated this function, What do you think?
Much nicer, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150528/new/

https://reviews.llvm.org/D150528