[PATCH] D151349: [HIP] emit macro `__HIP_NO_IMAGE_SUPPORT`

[Matt Arsenault via Phabricator via cfe-commits]

arsenm added a comment.

You seem to be defining a new subtarget feature without actually defining the underlying feature. I thought the issue was specific missing image instructions, which is already covered by extended-image-insts



================
Comment at: clang/lib/Basic/Targets/AMDGPU.h:458
+        HasImage = true;
+      else if (F == "-image-insts")
+        HasImage = false;
----------------
A negative form shouldn’t apply to targets with images, it will break the IR.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151349/new/

https://reviews.llvm.org/D151349