[PATCH] D151060: [Clang][Sema] Generate vector vs scalar builtin overloads

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added a comment.

Thanks for the fix! The changes should come with a release note.



================
Comment at: clang/lib/Sema/SemaOverload.cpp:9041-9044
+      // (allowing splatting the scalar to a vector).
+      for (unsigned Candidate = 0; Candidate < 2; ++Candidate) {
+        for (QualType Vec1Ty : CandidateTypes[Candidate].vector_types()) {
+          for (QualType Vec2Ty : CandidateTypes[Candidate].vector_types()) {
----------------
I'm a bit confused -- the comment says this is to allow splatting the scalar to a vector, but... what is the scalar type in these loops?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151060/new/

https://reviews.llvm.org/D151060