[PATCH] D151398: [clang] Make `FileEntryRef::getDir()` return the as-requested `DirectoryEntryRef`

Richard Howell via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 25 05:42:57 PDT 2023


rmaz accepted this revision.
rmaz added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: clang/include/clang/Basic/FileEntry.h:124
+    /// Directory the file was found in.
     OptionalDirectoryEntryRef Dir;
 
----------------
If this is always set now, should it be a non optional `DirectoryEntryRef`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151398/new/

https://reviews.llvm.org/D151398



More information about the cfe-commits mailing list