[PATCH] D148700: [clang] Add support for “regular” keyword attributes

Thu May 25 05:06:05 PDT 2023

aaron.ballman added a comment.

In D148700#4371518 <https://reviews.llvm.org/D148700#4371518>, @rsandifo-arm wrote:

> Thanks @aaron.ballman and @erichkeane for your patience in reviewing the patch and steering me in the right direction.
>
> What do you think about the other two patches in the series:
>
> - https://reviews.llvm.org/D148699 (comes before this one)
> - https://reviews.llvm.org/D148702 (comes after this one)
>
> The first one is pretty mechanical.  The second is going to be a slog to review, sorry.  It's one of those things that's much easier to write than to check afterwards.  I've tried to capture all the potentially non-obvious/non-mechanical parts in the covering note, but a long covering note might just make the review even more painful.  I'm happy to try presenting it in a different form if you can think of one that would help.
>
> Thanks again for accepting this patch, really appreciate it.

Thank you for the reminder about the other patches in the stack, I had lost track of those. I was able to review the first one today, but I don't think I'll have the bandwidth to get the second one done today (I'm about to head out for a ~week's vacation) so that one may take a bit longer.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148700/new/

https://reviews.llvm.org/D148700