[PATCH] D151426: [Clang][NFC] Prepare C++ DR suite for better test isolation
Vlad Serebrennikov via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu May 25 05:05:37 PDT 2023
Endill added a comment.
In D151426#4371730 <https://reviews.llvm.org/D151426#4371730>, @aaron.ballman wrote:
> The changes LGTM (verified off-list that the regenerated HTML is identical before and after this change),
I've run `make_cxx_dr_status` on top of this patch, and learned that the patch didn't change anything in `cxx_dr_status.html`, and that it has been written resilient enough to happily digest the new notation of status comments.
> but let's not land this until we've gotten farther along the review process with the related changes to split-file and the diagnostic verifier (just in case those reviews cause us to change direction for some reason).
I don't mind being cautious here. Even though initial feedback on every of them doesn't seem to reject the direction we've been pushing towards. Here are the patches we're waiting for:
- https://reviews.llvm.org/D150856
- https://reviews.llvm.org/D150990
- https://reviews.llvm.org/D151320
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151426/new/
https://reviews.llvm.org/D151426
More information about the cfe-commits
mailing list