[PATCH] D151201: [clang][dataflow] Fix a crash in `getLogicOperatorSubExprValue()`.

Martin Böhme via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 25 02:23:50 PDT 2023


mboehme marked an inline comment as done.
mboehme added inline comments.


================
Comment at: clang/unittests/Analysis/FlowSensitive/TransferTest.cpp:5064
+    bool target() {
+      return true || false || false || false;
+    }
----------------
xazax.hun wrote:
> Should we also test that the value of the expression is `true` in the analysis state?
Good point -- done.

I've also verified that this test continues to trigger the assert-fail if the fix is not present.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151201/new/

https://reviews.llvm.org/D151201



More information about the cfe-commits mailing list