[PATCH] D145739: [-Wunsafe-buffer-usage] Group variables associated by pointer assignments

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

In D145739#4370674 <https://reviews.llvm.org/D145739#4370674>, @barannikov88 wrote:

> Hi, just a heads-up, some bots seem to be unhappy with the test:
>
> https://lab.llvm.org/buildbot/#/builders/216/builds/21765
>
>   error: 'note' diagnostics expected but not seen: 
>     File Z:\b\llvm-clang-x86_64-sie-win\llvm-project\clang\test\SemaCXX\warn-unsafe-buffer-usage-multi-decl-warnings.cpp Line 169: {{^change type of 'q' to 'std::span' to preserve bounds information, and change 'r' and 'p' to 'std::span' to propagate bounds information between them$}}
>   error: 'note' diagnostics seen but not expected: 
>     File Z:\b\llvm-clang-x86_64-sie-win\llvm-project\clang\test\SemaCXX\warn-unsafe-buffer-usage-multi-decl-warnings.cpp Line 169: change type of 'q' to 'std::span' to preserve bounds information, and change 'p' and 'r' to 'std::span' to propagate bounds information between them
>   2 errors generated.

The test seems to randomly pass and fail on the bot. It seems that the order of 'p' and 'r' in the output string may not be deterministic? Can you make the test more reliable or make it handle each situation (if appropriate)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145739/new/

https://reviews.llvm.org/D145739