[PATCH] D151393: [CodeGen] Make __clang_call_terminate have an unwind table entry

[Eli Friedman via Phabricator via cfe-commits]

efriedma added inline comments.


================
Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:4698
+    if (CodeGenOpts.UnwindTables)
+      fn->setUWTableKind(llvm::UWTableKind(CodeGenOpts.UnwindTables));
+
----------------
We probably want to call SetLLVMFunctionAttributesForDefinition() here instead.  The end result isn't that much different, but it indicates the intent more clearly, and hopefully we avoid hitting similar issues in this code in the future.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151393/new/

https://reviews.llvm.org/D151393