[PATCH] D151194: [clang][dataflow] Add support for return values of reference type.

Gábor Horváth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 24 20:07:50 PDT 2023


xazax.hun accepted this revision.
xazax.hun added inline comments.


================
Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:196
+  void popCall(const CallExpr *Call, const Environment &CalleeEnv);
+  void popCall(const CXXConstructExpr *Call, const Environment &CalleeEnv);
 
----------------
I know that Obj-C is a non-goal, but it might worth a comment to support `ObjCMessageExpr` just in case someone wants to work on this. 

Btw, this is one of my biggest pet peeves about the Clang AST. We should have a common abstraction for all the callables, instead of having to bifurcate many of the APIs. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151194/new/

https://reviews.llvm.org/D151194



More information about the cfe-commits mailing list