[PATCH] D151162: Add -Wpacked-non-pod to -Wall

[Zenong Zhang via Phabricator via cfe-commits]

SlaterLatiao added inline comments.


================
Comment at: clang/test/CodeGenCXX/warn-padded-packed.cpp:5
+// RUN: %clang_cc1 -triple=x86_64-none-none -Wpacked-non-pod -verify=top %s -emit-llvm-only
+// RUN: %clang_cc1 -triple=x86_64-none-none -Wpacked-non-pod -fclang-abi-compat=15 %s -emit-llvm-only
+
----------------
denik wrote:
> Probably we don't need this one. But I'm not sure if there is any impact of the abi on`packed-non-pod`. According to the original test it checks only `-Wpacked` `packed attribute is unnecessary` warning.
I added this line to make sure all the `packed attribute is unnecessary` warnings in the existing test of  `-Wpacked` are not reported by  `-Wpacked-non-pod`. Yeah if the abi doesn't have any impact on `-Wpacked-non-pod` this test is unnecessary. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151162/new/

https://reviews.llvm.org/D151162