[PATCH] D151186: [Driver] Properly handle -pie and -nopie on Fuchsia

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 24 10:51:27 PDT 2023


MaskRay added a comment.

In D151186#4369181 <https://reviews.llvm.org/D151186#4369181>, @phosek wrote:

> That alias is already recognized by the GNU driver. I'm sharing the implementation between the two drivers. Would you prefer to reject `-nopie` when targeting Fuchsia?

Hmm, handling `OPT_nopie` in `clang/lib/Driver/ToolChains/Gnu.cpp` looks like a mistake. We should reject it for Gnu.cpp...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151186/new/

https://reviews.llvm.org/D151186



More information about the cfe-commits mailing list