[PATCH] D151342: [Clang] Correctly handle generic lambda used as default template argument.

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 24 10:00:10 PDT 2023


erichkeane accepted this revision.
erichkeane added a comment.
This revision is now accepted and ready to land.

So I think this is the right approach here.  Unfortunately my knowledge of the parser is a little wonky, so I don't feel comfortable JUST approving this right away(though it DOES look correct to me).  I'd like to give other folks a day or two to take a look.  I've added the lang-wg, so please give them a day or two to point out why I'm an idiot here before committing this.



================
Comment at: clang/lib/Parse/ParseTemplate.cpp:850
+    TemplateParameterDepthRAII CurTemplateDepthTracker(TemplateParameterDepth);
+    CurTemplateDepthTracker.addDepth(1);
     DefaultArg =
----------------
Same below.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151342/new/

https://reviews.llvm.org/D151342



More information about the cfe-commits mailing list