[PATCH] D151192: [clang-tidy] have bugprone-unchecked-optional-access check boost::optional usage

[Giel van Schijndel via Phabricator via cfe-commits]

muggenhor added a comment.

FYI: I've added a set of tests. But in the process discovered there's at least one assumption that doesn't hold for boost::optional. So I'll have to adjust the implementation for that. That's a bit more involved change, so will take some time.

(Specifically the assumption is that converting constructors/assignment operators are templates themselves: `assert(F.getTemplateSpecializationArgs() != nullptr);` in `valueOrConversionHasValue`).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151192/new/

https://reviews.llvm.org/D151192