[PATCH] D151300: [clang][Diagnostics][NFC] Remove unnecessary StringRef

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM, but it's worth noting that `std::string::pop_back()` calls `erase()` and there's no guarantee that there's not an extra allocation involved as a result. However, I've not seen evidence that STLs actually do an allocation (looking at libc++ and MSVC STL, they don't appear to allocate), so I think this is fine.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151300/new/

https://reviews.llvm.org/D151300