[PATCH] D151145: Add disabled unittest reproducing TextProto formatting issue.
Krasimir Georgiev via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed May 24 01:56:56 PDT 2023
krasimir added a comment.
Thank you! That's a bug in the raw string format manager.
This code effectively first looks for a matching top-level style, and if that's not found, then it tries to derive one via the RawFormat's BasedOnStyle:
https://github.com/llvm/llvm-project/blob/main/clang/lib/Format/ContinuationIndenter.cpp#L191-L201
This doesn't match the documentation of the BasedOnStyle field, which indicates that, if specified, it should take precedence:
https://github.com/llvm/llvm-project/blob/main/clang/include/clang/Format/Format.h#L3219-L3222
@Icantjuddle would you like to update this patch to fix the issue and enable your newly added tests?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151145/new/
https://reviews.llvm.org/D151145
More information about the cfe-commits
mailing list