[PATCH] D150635: [clangd] Implement end-definition-comment inlay hints

Tue May 23 21:56:43 PDT 2023

sammccall added a comment.

In D150635#4366730 <https://reviews.llvm.org/D150635#4366730>, @daiyousei-qz wrote:

> I'm not sure but 18ms is definitely wrong here, especially for a debug build. In your log, even semantic highlighting builds in 60ms, which looks incorrect. I tried again with TOT clangd and noticed the following pattern.
>
> - If I scroll with vscode, inlay hints typically computes in 10~20ms
> - If I edit the source code, inlay hints computes in around 600ms

That sounds exactly like rebuilding the AST takes ~600ms and computing inlay hints takes <20ms.

After an edit, a request for inlay hints will wait while the AST rebuilds before computing inlay hints, so the request latency will show as ~620ms.

If you think you're seeing something else, please provide repro instructions and logs (with -log=verbose)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150635/new/

https://reviews.llvm.org/D150635