[PATCH] D151253: [clangd] Move completion signatures and insertion markers into labelDetails

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 23 13:40:13 PDT 2023


sammccall created this revision.
sammccall added a reviewer: hokein.
Herald added subscribers: kadircet, arphaman.
Herald added a project: All.
sammccall requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.

(When clients support it, otherwise keep the existing rendering).

In VSCode this moves the markers to the right, and makes the signature darker.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D151253

Files:
  clang-tools-extra/clangd/ClangdLSPServer.cpp
  clang-tools-extra/clangd/ClangdLSPServer.h
  clang-tools-extra/clangd/CodeComplete.cpp
  clang-tools-extra/clangd/Protocol.cpp
  clang-tools-extra/clangd/Protocol.h
  clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D151253.524865.patch
Type: text/x-patch
Size: 8191 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230523/e4f1e65c/attachment-0001.bin>


More information about the cfe-commits mailing list