[PATCH] D151235: [Clang] Switch from TransformExpr to TransformInitializer in places we need to revert initializer to it syntactic form for Sema

[Erich Keane via Phabricator via cfe-commits]

erichkeane added a comment.

Change looks good, test is overly specific IMO.



================
Comment at: clang/test/CodeGenCXX/gh62818.cpp:27
+  // CHECK: %[[ASSIGN:.+]] = call noundef nonnull align 1 dereferenceable(1) %struct.A* @_ZNR1AaSES_(%struct.A* noundef nonnull align 1 dereferenceable(1) %[[MEMBER_A]], %struct.A* noundef %[[LHS]])
+  // CHECK: call void @_ZN1AD1Ev(%struct.A* noundef nonnull align 1 dereferenceable(1) %[[LHS]])
+
----------------
This test seems a little overly specific, right?  I suspect you really only need `call{{.*}} <ctor>`, `copy` and `dtor` here.  The rest seems unnecessary.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151235/new/

https://reviews.llvm.org/D151235