[PATCH] D149495: [RISCV] Add support for V extension in SiFive7

Tue May 23 07:44:47 PDT 2023

michaelmaitland added inline comments.

================
Comment at: llvm/lib/Target/RISCV/RISCVScheduleV.td:41

+// Helper function to get the largest LMUL from MxList
+// Precondition: MxList is sorted in ascending LMUL order.
----------------
michaelmaitland wrote:
> pcwang-thead wrote:
> > So, are we going to discard `LMULXXXImpl` below?
> I will use `LMULXXXImpl` in a follow up NFC patch. This code below comes from before `LMULXXXImpl` was introduced.
Can you please provide an example of how you intend on this being used today? I think it depends on https://reviews.llvm.org/D146198 since if we use `LMULXXXImpl` today, there is no way to differentiate behavior based on LMUL.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149495/new/

https://reviews.llvm.org/D149495