[PATCH] D151042: [clang] Add tests for CWG issues 977, 1482, 2516

Tue May 23 05:36:25 PDT 2023

thakis added a comment.

In D151042#4364131 <https://reviews.llvm.org/D151042#4364131>, @Endill wrote:

> All tests pass for me on Linux.
> As far as I understand, diagnostics on Windows are not supposed to be different given the same `-cc1` flags. Reverting for further investigation.

Thanks for the revert. The test also failed on the official llvm win buildbot here https://lab.llvm.org/buildbot/#/builders/123 fwiw (but it takes a long time to load).

Diagnostics on windows absolutely can be different on windows with the same cc1 flags. Clang uses the host system's target triple, and for (say) x86_64-pc-windows clang runs in MS mode, which enables some cl.exe compatibility things.

In fact, you can probably repro the test failure on your linux box if you change that test and add locally add `-triple=i386-pc-win32` to the RUN line (or maybe the behavior to enable MS extensions based on target lives in the driver; in that case you'd have to add `-fms-extensions -fms-compatibility`).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151042/new/

https://reviews.llvm.org/D151042