[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

[Corentin Jabot via Phabricator via cfe-commits]

cor3ntin added a comment.

Thanks, It's great to have the complete feature in on PR



================
Comment at: clang/include/clang/Sema/Sema.h:9661
+    struct BuildingDeductionGuides {};
+    /// Note that we are instantiating an exception specification
+    /// of a function template.
----------------
Is that comment correct?


================
Comment at: clang/lib/Sema/SemaDecl.cpp:12637
 
-  if (DirectInit) {
-    if (auto *PL = dyn_cast_or_null<ParenListExpr>(Init))
-      DeduceInits = PL->exprs();
-  }
+  auto *PL = dyn_cast_or_null<ParenListExpr>(Init);
+  if (DirectInit && PL)
----------------



================
Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:1059-1062
+    case CodeSynthesisContext::BuildingDeductionGuides:
+      assert(
+          false &&
+          "failed building deduction guides, add meaningful diagnostics here");
----------------
This seems unfinished


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139837/new/

https://reviews.llvm.org/D139837