[PATCH] D123649: Allow flexible array initialization in C++.

Eli Friedman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 22 15:51:17 PDT 2023


efriedma added a comment.

In D123649#4362418 <https://reviews.llvm.org/D123649#4362418>, @aaron.ballman wrote:

> In D123649#4362402 <https://reviews.llvm.org/D123649#4362402>, @efriedma wrote:
>
>> The assertion is correct; without it, your code is getting miscompiled.
>
> The assertion may be correct in its intent, but we still should not be asserting in practice: https://godbolt.org/z/cs5bhvPGr

I wasn't trying to suggest our behavior is correct here, just that focusing assertion is correctly indicating an underlying issue with the generated IR.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123649/new/

https://reviews.llvm.org/D123649



More information about the cfe-commits mailing list