[PATCH] D151034: [clang] Add test for CWG1397

Mon May 22 12:11:55 PDT 2023

Endill added a comment.

Thank you for the review!

================
Comment at: clang/test/CXX/drs/dr13xx.cpp:488
+#if __cplusplus == 201103L
+  // expected-error@#dr1397-struct-A {{default member initializer for 'p' needed within definition of enclosing class 'A' outside of member functions}}
+  // expected-note@#dr1397-void-p {{in evaluation of exception specification for 'dr1397::A::A' needed here}}
----------------
shafik wrote:
> These diagnostic are pretty bad, maybe provide a comment above explaining them a little better or maybe better refactor the diagnostic?
Totally agree about diagnostic not being accessible. I filed [[ https://github.com/compiler-explorer/infra/blob/fa7c4cf145898d989cb3a33e49f2a1223107eeac/bin/yaml/cpp.yaml#L648 | a bug]] for that, but not sure how to refactor it.

I don't think it's a good place to explain complicated diagnostic messages, though. If someone is interested enough, intent could be seen on this review and in CWG1397 itself. We better just fix the diagnostic, and expected message together with it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151034/new/

https://reviews.llvm.org/D151034