[PATCH] D151061: [test] Add ext_vector_type tests for C

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 22 09:21:33 PDT 2023


aaron.ballman added a comment.

Thank you for the additional test coverage! The changes LGTM modulo the suggestion from @fhahn on how to improve the comments. (Note, given your goal of verifying that operations work, you might want to consider adding similar coverage for CodeGen tests to verify that we emit sensible LLVM IR for each of these operations as well, if we don't already have sufficient coverage for it.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151061/new/

https://reviews.llvm.org/D151061



More information about the cfe-commits mailing list