[PATCH] D151040: [NFC][CLANG] Fix static code analyzer concerns

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 22 06:15:23 PDT 2023


erichkeane added inline comments.


================
Comment at: clang/lib/AST/ExprConstant.cpp:10172
       Info.Ctx.getAsConstantArrayType(E->getSubExpr()->getType());
+  assert(ArrayType && "unexpected type for array initializer");
 
----------------
I think this ends up being a regression if the LValue doesn't evaluate right.  This should probably go down near 10179.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151040/new/

https://reviews.llvm.org/D151040



More information about the cfe-commits mailing list