[PATCH] D150840: [clang][NFC] Refactor emitSnippet()

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 22 04:59:22 PDT 2023


aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

In D150840#4359570 <https://reviews.llvm.org/D150840#4359570>, @tbaeder wrote:

> Side-note: The `ToPrint` stuff here is just useful to "cache" the output string, isn't it? Is that really useful? I'd expect the output stream to be cached anyway?

Yeah, that does seem like a kind of caching operation, I'm not certain what it's purpose is though.

LGTM!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150840/new/

https://reviews.llvm.org/D150840



More information about the cfe-commits mailing list