[PATCH] D148206: [clang] Do not crash after suggesting typo correction to constexpr if condition

Mariya Podchishchaeva via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 22 03:37:05 PDT 2023


Fznamznon added inline comments.


================
Comment at: clang/test/SemaCXX/invalid-if-constexpr.cpp:7
+}
+void a() { if constexpr (__adl_swap<>) {}} // expected-error{{use of undeclared identifier '__adl_swap'; did you mean '__sync_swap'?}} \
+                                           // expected-note {{'__sync_swap' declared here}}
----------------
zixuan-wu wrote:
> Hi, why  `did you mean '__sync_swap'` is not reported in riscv target? So it's failed in check-all.
I haven't seen any buildbot issues with the issue like this.
Adding -triple riscv64-unknown-unknown doesn't help me to see the issue, as well as adding -DLLVM_TARGETS_TO_BUILD="RISCV" to cmake line and running check-clang. Could you please help to reproduce the issue? I'm not quite familiar with RISCV targets.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148206/new/

https://reviews.llvm.org/D148206



More information about the cfe-commits mailing list