[PATCH] D148851: Disable llvm-symbolizer on some of the driver tests that are timing out

Sat May 20 12:34:34 PDT 2023

delcypher added a comment.

@ahatanak Thanks for working on this. I think that annotating these particular tests so that's clear that they are supposed to crash (and therefore symbolication is of no use) is a good change. If we want to make a more global change for tests I think that should be handled separately.

However, if `not --crash` does the job of disabling symbolication I think we should use that because it also documents that we expect the binary being executed to crash. If you make that change then I'm happy to approve.

================
Comment at: clang/test/Driver/crash-diagnostics-dir-3.c:4
 // RUN: rm -rf %t
 // RUN: not env CLANG_CRASH_DIAGNOSTICS_DIR=%t %clang -c %s -o - 2>&1 | FileCheck %s
 #pragma clang __debug parser_crash
----------------
Should we use `not --crash` instead? It's more explicit that we are expecting a crash and IIRC should disable symbolization as well.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148851/new/

https://reviews.llvm.org/D148851