[PATCH] D150997: [llvm] Split out DenseMapInfo<variant> specialization

Elliot Goodrich via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat May 20 04:48:58 PDT 2023


IncludeGuardian added inline comments.


================
Comment at: llvm/include/llvm/ADT/DenseMapInfo.h:321
-  static bool isEqual(const Variant &LHS, const Variant &RHS) {
-    return LHS == RHS;
-  }
----------------
Regardless of this change, I think the equality here needs to be fixed in the future to delegate to `DenseMapInfo` for checking equality of the contents of the `std::variant`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150997/new/

https://reviews.llvm.org/D150997



More information about the cfe-commits mailing list