[PATCH] D140828: [C++] Implement "Deducing this" (P0847R7)

[Vlad Serebrennikov via Phabricator via cfe-commits]

Endill added a comment.

Thank you for working on this feature!
I can't review this properly, so here's my little help for the feature I'm looking forward to very much.



================
Comment at: clang/test/CXX/drs/dr25xx.cpp:1
-// RUN: %clang_cc1 -std=c++20 -triple x86_64-unknown-unknown %s -verify
+// RUN: %clang_cc1 -std=c++20 -Wno-c++2b-extensions -triple x86_64-unknown-unknown %s -verify
+// RUN: %clang_cc1 -std=c++2b -triple x86_64-unknown-unknown %s -verify
----------------
Better get C++23-specific tests under `#ifdef __cplusplus >= 202302L`, because compiler options have more global effect. 


================
Comment at: clang/test/CXX/drs/dr25xx.cpp:2
+// RUN: %clang_cc1 -std=c++20 -Wno-c++2b-extensions -triple x86_64-unknown-unknown %s -verify
+// RUN: %clang_cc1 -std=c++2b -triple x86_64-unknown-unknown %s -verify
+
----------------
`c++23` mode is available now, and Erich converted all `c++2b` to `c++23` across DR tests (at least). I think you also need a RUN line for `c++2c` mode now.


================
Comment at: clang/test/CXX/drs/dr25xx.cpp:4
+
+namespace dr2553 { // dr2553: 16 open
+struct B {
----------------
Please, don't forget to update the version before landing. Spotting this retroactively could be difficult.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140828/new/

https://reviews.llvm.org/D140828