[PATCH] D150817: Use windows baskslash on anonymous tag locations if using MSVCFormatting and it's not absolute path.

Hans Wennborg via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri May 19 04:04:18 PDT 2023


hans accepted this revision.
hans added a comment.

Nice! lgtm



================
Comment at: clang/lib/AST/TypePrinter.cpp:1391
+          WrittenFile = Callbacks->remapPath(File);
+        // The following tries to fix inconsistent path separator created by
+        // clang::DirectoryLookup::LookupFile when the file path is relative
----------------
nit: If you want you could drop the "The following tries to" part to make this more concise.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150817/new/

https://reviews.llvm.org/D150817



More information about the cfe-commits mailing list