[PATCH] D147916: [10/11][POC][Clang][RISCV] Define vget for tuple type

Yueh-Ting (eop) Chen via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 18 20:16:24 PDT 2023


eopXD added inline comments.


================
Comment at: clang/include/clang/Basic/riscv_vector.td:2602
+          unsigned MaxIndex = cast<StructType>(VTupleOperand->getType())->getNumElements();
+          Index = std::min(Index, MaxIndex);
+
----------------
craig.topper wrote:
> Does this `min` do anything or does SemaChecking already guarantee it?
Yes, SemaChecking should be able to guard the value correctly and this line is redundant.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147916/new/

https://reviews.llvm.org/D147916



More information about the cfe-commits mailing list