[PATCH] D150411: [NFC][Clang][Coverity] Fix Static Code Analysis Concerns with copy without assign
Soumi Manna via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu May 18 13:41:23 PDT 2023
Manna added inline comments.
================
Comment at: clang/include/clang/Sema/ParsedAttr.h:705-707
+ // The move assignment operator is defined as deleted pending further
+ // motivation.
+ AttributePool &operator=(AttributePool &&pool) = delete;
----------------
tahonermann wrote:
> Let's explicitly delete the copy assignment operator too since the copy constructor is deleted.
@tahonermann , copy assignment operator has already been explicitly deleted at line no 701. I made this change part of https://reviews.llvm.org/D149718. It was a rebase issue, so it did show it before with my previous patch. I have fixed it now and added comment since the copy assignment was added explicitly as deleted.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150411/new/
https://reviews.llvm.org/D150411
More information about the cfe-commits
mailing list