[PATCH] D150689: [clang][DependencyScanner] Remove all warning flags when suppressing warnings

Juergen Ributzka via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 18 12:29:07 PDT 2023


ributzka added inline comments.


================
Comment at: clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp:50
+  // optimize.
+  if (!IsSystemModule)
+    return;
----------------
This removes also all warnings when building your own module, because of the `[system]` attribute. I would prefer this optimization to be limited to modules that are in the sysroot and therefore ignore the `[system]` attribute. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150689/new/

https://reviews.llvm.org/D150689



More information about the cfe-commits mailing list