[PATCH] D147774: [4/11][POC][Clang][RISCV] Define tuple type variant of vsseg2e32

Craig Topper via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 18 10:40:16 PDT 2023


craig.topper added inline comments.


================
Comment at: clang/include/clang/Basic/riscv_vector.td:1575
+      unsigned Offset = IsMasked ? 1 : 0;
+      llvm::Value *MaskOperand = IsMasked ? Ops[0] : nullptr;
+      llvm::Value *PtrOperand = Ops[Offset];
----------------
Similar comment to patch 3. We can index the Ops array directly in the push_back calls instead of having temporary variables.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147774/new/

https://reviews.llvm.org/D147774



More information about the cfe-commits mailing list