[PATCH] D150872: [clang-tidy] Add support for new TODO style to google-readability-todo

Yitzhak Mandelbaum via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 18 10:32:38 PDT 2023


ymandel marked 3 inline comments as done.
ymandel added a comment.

Thank you for the very fast review!



================
Comment at: clang-tools-extra/clang-tidy/google/TodoCommentCheck.cpp:97
     : ClangTidyCheck(Name, Context),
+      UseV2Style(Options.getLocalOrGlobal("UseV2Style", false)),
       Handler(std::make_unique<TodoCommentHandler>(
----------------
njames93 wrote:
> Given this check is part of the google module, doesn't it make sense to have the default as what google now recommends.
The style guide hasn't been updated yet. Once that happens, I think we should switch the default. I can add a FIXME -- what do you think?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150872/new/

https://reviews.llvm.org/D150872



More information about the cfe-commits mailing list