[PATCH] D146873: [2/11][POC][Clang][RISCV] Define RVV tuple types

[Craig Topper via Phabricator via cfe-commits]

craig.topper accepted this revision.
craig.topper added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/lib/CodeGen/CGCall.cpp:3135
           STy->getNumElements() > 1) {
-        uint64_t SrcSize = CGM.getDataLayout().getTypeAllocSize(STy);
-        llvm::Type *DstTy = Ptr.getElementType();
-        uint64_t DstSize = CGM.getDataLayout().getTypeAllocSize(DstTy);
+        if (STy->containsScalableVectorType()) {
+          assert(STy->containsHomogeneousScalableVectorTypes() &&
----------------
Can we call `CGM.getDataLayout().getTypeAllocSize(STy)` and check if the TypeSize returned isScalable instead of calling containsScalableVectorType?


================
Comment at: clang/test/CodeGen/RISCV/rvv-intrinsics-handcrafted/rvv-tuple-type-1.c:1
+// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 2
+// RUN: %clang_cc1 -triple riscv64 -target-feature +zve32x -disable-O0-optnone \
----------------
Do these two tests have the same content but different RUN lines? Can we merge them with 2 different RUN lines?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146873/new/

https://reviews.llvm.org/D146873