[PATCH] D150875: Make dereferencing a void* a hard-error instead of warn-as-error

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 18 09:56:19 PDT 2023


erichkeane added a comment.

In D150875#4353209 <https://reviews.llvm.org/D150875#4353209>, @rupprecht wrote:

> I found one use here: https://github.com/ericniebler/range-v3/blob/48dc2eb666c07e6afc8ec5edf7db9a5c6cde7a56/include/range/v3/functional/invoke.hpp#L51

Huh, that is an interesting use!  I notice that he enables that for both GCC AND Clang, but probably doesn't notice because he disables Wpragma as well.  So this change would change the legality of his program (potentially) for Clang (though, we ALREADY would have broken any SFINAE/concepts uses because of the SFINAE change in 16), but only to be what GCC gives him?  I think we can be ok with that?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150875/new/

https://reviews.llvm.org/D150875



More information about the cfe-commits mailing list