[PATCH] D146358: [clang][AST] Print name instead of type when diagnosing uninitialized subobject in constexpr variables

Thu May 18 06:46:34 PDT 2023

erichkeane added a comment.

In D146358#4351787 <https://reviews.llvm.org/D146358#4351787>, @hazohelet wrote:

> In D146358#4350810 <https://reviews.llvm.org/D146358#4350810>, @erichkeane wrote:
>
>> Our downstream discovered that this causes a regression when compiling `utility` with `ast-dump`.  I've put up a minimal reproducer: https://godbolt.org/z/oaezas7Ws
>>
>> @hazohelet : Will you be able to look into this soon?
>
> Thanks for the report and the reproducer.
> I cannot take sufficient time for about 36 hours, but I'll be able to investigate it after that.

That is long enough away that I unfortunately have to revert (see 34e49d3e85a6dd03856af0fb4b7f8d8ae1f4f06a <https://reviews.llvm.org/rG34e49d3e85a6dd03856af0fb4b7f8d8ae1f4f06a>). Please note that in the LLVM project reverts are common/frequent (we have a policy of 'revert often'), and should not be taken negatively!  Please feel free to re-submit this patch with a fix/the test provided, and we'll re-review promptly!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146358/new/

https://reviews.llvm.org/D146358