[PATCH] D150670: [WebAssembly] Disable generation of fshl/fshr for rotates

Craig Topper via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 18 00:20:02 PDT 2023


craig.topper added a comment.

> Preventing the simplification means adding target specific code in instcombine which seems even worse than adding it here given as @dschuff 
> pointed out, there's precedent with x86.

How harmful is it to avoid breaking rotate patterns even if the target doesn't support rotate?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150670/new/

https://reviews.llvm.org/D150670



More information about the cfe-commits mailing list