[PATCH] D150183: [Clang][clang-cl] Implement `__builtin_FUNCSIG`

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added a comment.

Thank you! In general, this is looking pretty close to ready.



================
Comment at: clang/lib/Parse/ParseExpr.cpp:807-809
+/// [C++11] simple-type-specifier braced-init-list                [C++11 5.2.3]
 /// [C++]   typename-specifier '(' expression-list[opt] ')'         [C++ 5.2.3]
+/// [C++11] typename-specifier braced-init-list                   [C++11 5.2.3]
----------------
Might as well revert the clang-format changes here.


================
Comment at: clang/test/Preprocessor/feature_tests.c:1-2
-// RUN: %clang_cc1 %s -triple=i686-apple-darwin9 -target-cpu pentium4 -verify -DVERIFY
-// RUN: %clang_cc1 %s -E -triple=i686-apple-darwin9 -target-cpu pentium4
+// RUN: %clang_cc1 %s -triple=i686-apple-darwin9 -target-cpu pentium4 -fms-extensions -verify -DVERIFY
+// RUN: %clang_cc1 %s -E -triple=i686-apple-darwin9 -target-cpu pentium4 -fms-extensions
 #ifndef __has_feature
----------------
We should continue to have non-ms-extension RUN lines as well. (This is testing feature tests, so enabling ms extensions can impact things in surprising ways and we don't want to lose coverage for non-ms modes.)


================
Comment at: clang/test/Sema/source_location.c:1-2
-// RUN: %clang_cc1 -std=c90 -fconst-strings -DCONST_STRINGS -verify %s
-// RUN: %clang_cc1 -std=c90 -verify %s
+// RUN: %clang_cc1 -std=c90 -fms-extensions -fconst-strings -DCONST_STRINGS -verify %s
+// RUN: %clang_cc1 -std=c90 -fms-extensions -verify %s
 
----------------
I would add a RUN line for -fms-extensions, same as above.


================
Comment at: clang/test/SemaCXX/source_location.cpp:1
-// RUN: %clang_cc1 -std=c++1z -fcxx-exceptions -fexceptions -verify %s
-// RUN: %clang_cc1 -std=c++2a -fcxx-exceptions -DUSE_CONSTEVAL -fexceptions -verify %s
+// RUN: %clang_cc1 -std=c++1z -fcxx-exceptions -fms-extensions -fexceptions -verify %s
+// RUN: %clang_cc1 -std=c++2a -fcxx-exceptions -fms-extensions -DUSE_CONSTEVAL -fexceptions -verify %s
----------------
Same here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150183/new/

https://reviews.llvm.org/D150183