[PATCH] D150730: [Clang][Sema] Substitute constraints only for declarations with different lexical contexts

Shafik Yaghmour via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 17 10:26:41 PDT 2023


shafik added inline comments.


================
Comment at: clang/lib/Sema/SemaConcept.cpp:783
     return true;
-  if (Old && New && Old != New) {
+  if (Old && New && Old != New &&
+      Old->getLexicalDeclContext() != New->getLexicalDeclContext()) {
----------------
erichkeane wrote:
> Please put the standards quote that supports this here, it'll be really useful in the future.(temp.constr.decl p4)
Yes, the change makes a lot more sense with the quote. 




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150730/new/

https://reviews.llvm.org/D150730



More information about the cfe-commits mailing list