[PATCH] D150775: [clang][dataflow] Fix a bug in handling of `operator->` for optional checker.

Yitzhak Mandelbaum via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 17 07:15:49 PDT 2023


ymandel accepted this revision.
ymandel added a comment.
This revision is now accepted and ready to land.

Nice catch!



================
Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:789
-      // of these accessors.
-      .CaseOfCFGStmt<CallExpr>(valueOperatorCall(std::nullopt),
                                [](const CallExpr *E,
----------------
this function will be left with only one caller. Maybe inline it? For that matter, should the other caller be changed in some parallel way?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150775/new/

https://reviews.llvm.org/D150775



More information about the cfe-commits mailing list